Config recovery glue: expose current group config bytes for re-store - #65
Merged
Bilb merged 1 commit intoAug 5, 2026
Merged
Conversation
Desktop's config recovery needs to put a group config back on the swarm after it expired from there. push() returns null for a sub-config with nothing to send, so there was no way to ask for the bytes of a config that is already clean. - pushForRecovery(): the current serialised GroupInfo and GroupMembers, whether or not they need pushing. groupKeys is deliberately absent — a stored keys message cannot be re-emitted, only replaced by an admin rekey. It still drains the obsolete-hash list as push() does, so the caller must issue the delete for the hashes it hands back. - activeHashesByConfig(): the same hashes as activeHashes() but kept per sub-config, so a caller can tell a re-storable GroupInfo/GroupMembers hash from a groupKeys hash that only a rekey can replace. Both additive; no existing behaviour changes.
Bilb
approved these changes
Aug 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Desktop's config recovery needs to put a group config back on the swarm after it expired from there. push() returns null for a sub-config with nothing to send, so there was no way to ask for the bytes of a config that is already clean.
Both additive; no existing behaviour changes.