feat: trust Sucuri's IP Addresses on nginx #595
Closed
+7
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
It would be nice if this could be made easily configurable for any upstream ranges I want. |
Author
|
This is already configurable by mounting an additional .conf file, which is what I'm doing currently |
Contributor
|
I already feel that the trust is too wide. |
Member
|
I appreciate your time on this PR, but I had another issue where I had to restructure a bunch of web server configs and I was able to get this done on another PR: I would have merged this, but it would have been too complicated with the merge conflicts. I also separated out the configs so you're only loading what you need. Thanks for your contributions! I look forward to reviewing another PR from you again in the future. |
Author
|
Appreciate the update, looking forward to checking out the restructure on the server configs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Siimilar to Cloudflare, Sucuri is a popular proxy/firewall service provider. This PR adds their trusted/secured ips for the nginx images
Found here under the 502:
https://docs.sucuri.net/website-firewall/sucuri-firewall-troubleshooting-guide/