docs: Adds docs for Facebook Identity provider#412
Open
vfiruz97 wants to merge 3 commits intoserverpod:mainfrom
Open
docs: Adds docs for Facebook Identity provider#412vfiruz97 wants to merge 3 commits intoserverpod:mainfrom
vfiruz97 wants to merge 3 commits intoserverpod:mainfrom
Conversation
vfiruz97
force-pushed
the
docs/auth-facebook
branch
from
5c9241b to
2c0ff89
Compare
vfiruz97
force-pushed
the
docs/auth-facebook
branch
from
2c0ff89 to
e7ca7c0
Compare
Collaborator
@vfiruz97 Nice PR! As a general guideline, I think we can apply most of the comments of the Microsoft docs PR here as well (title casing/style guide adjustments, usage of the *FromPasswords class on the configs examples, GetExtraFacebookInfoCallback). Could you pair them up and make a review based on that feedback? Then I can quickly scan if there is something else left. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @marcelomendoncasoares,
Adds docs for serverpod/serverpod#4689. Please review when you have a chance.