Fix #1354 - Isolate variables in ForExecutor to avoid racing condition to overwrite loop variables

[ricardozanini]

Many thanks for submitting your Pull Request ❤️!

What this PR does / why we need it:
Fixes #1354

Special notes for reviewers:

• I changed the InMemoryEvents class slightly to be inherit-friendly
• Moved TranceExecutionListener to impl so it can easily be reused in other tests and in client code - it's quite useful for debugging/tracing, even in prod code.

Additional information (if needed):

[Copilot]

Pull request overview

This PR addresses issue #1354 by changing how ForExecutor handles loop variables to prevent async tasks (e.g., emit) from observing overwritten $item/$index values. It also refactors supporting test utilities by making InMemoryEvents subclass-friendly, introducing a lagged event broker for deterministic async tests, and relocating TraceExecutionListener into impl code for reuse.

Changes:

• Update ForExecutor to capture per-iteration loop values and reapply them at execution time in the async chain.
• Make InMemoryEvents fields protected/final to support subclassing; add LaggedInMemoryEvents for regression testing async behavior.
• Move TraceExecutionListener into io.serverlessworkflow.impl.lifecycle and update tests/tools to import it from the new package.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
impl/test/src/test/java/io/serverlessworkflow/impl/test/MvStorePersistenceTest.java	Update import to new TraceExecutionListener package.
impl/test/src/test/java/io/serverlessworkflow/impl/test/DBGenerator.java	Update import to new TraceExecutionListener package.
impl/core/src/main/java/io/serverlessworkflow/impl/lifecycle/TraceExecutionListener.java	Change package to impl.lifecycle (and remove now-redundant imports).
impl/core/src/main/java/io/serverlessworkflow/impl/executors/ForExecutor.java	Attempt to fix foreach race by capturing item/index and re-setting variables in the async callback.
impl/core/src/main/java/io/serverlessworkflow/impl/events/InMemoryEvents.java	Expose internals as protected to allow inheritance in tests/client code.
experimental/test/src/test/java/io/serverlessworkflow/fluent/test/LaggedInMemoryEvents.java	New lagged publisher used to make async foreach behavior reproducible.
experimental/test/src/test/java/io/serverlessworkflow/fluent/test/ForEachFuncTest.java	Switch to lagged broker and add listener to help validate the foreach/emit regression.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

[fjtirado]

Please put back traceExecutionListerns as test class.
This will avoid unrelated change in DBGbenrator and MvStorePersistenceTest.

[fjtirado]

@ricardozanini Nice pr that fixes that particular race condition, but I realized that ForExecutor was not properly implemented, there are more race conditions and opened this alternate one, please take a look
#1369, if you agree, I think we can close this one

[Copilot]

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.