feat: Add and style leaf nodes#136
Open
lornakelly wants to merge 1 commit intoserverlessworkflow:mainfrom
Open
feat: Add and style leaf nodes#136lornakelly wants to merge 1 commit intoserverlessworkflow:mainfrom
lornakelly wants to merge 1 commit intoserverlessworkflow:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds the agreed UX styling for “leaf” task nodes in the React Flow diagram editor by introducing a shared TaskNodeContent component backed by a per-node-type config map, plus corresponding CSS and tests. This moves several leaf nodes off placeholders and updates sizing to better fit the new visual design.
Changes:
- Introduces
taskNodeConfigMap(color/icon/type label) for leaf task nodes and adds unit tests to ensure completeness/shape. - Implements
TaskNodeContentand wires leaf nodes (Call/Emit/Listen/Raise/Run/Set/Switch/Wait) to render with the new styled content. - Updates diagram CSS for light/dark themes and increases default node dimensions.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/serverless-workflow-diagram-editor/tests/react-flow/nodes/taskNodeConfig.test.ts | Adds coverage ensuring all leaf node types have config entries with expected fields. |
| packages/serverless-workflow-diagram-editor/tests/react-flow/nodes/Nodes.test.tsx | Expands node rendering tests and validates leaf node DOM/config integration. |
| packages/serverless-workflow-diagram-editor/src/react-flow/nodes/taskNodeConfig.ts | Defines leaf node visual config (colors/icons/type labels). |
| packages/serverless-workflow-diagram-editor/src/react-flow/nodes/Nodes.tsx | Adds TaskNodeContent and switches leaf nodes to styled rendering using config. |
| packages/serverless-workflow-diagram-editor/src/react-flow/diagram/Diagram.tsx | Updates sample diagram node labels/positions to better demonstrate new nodes. |
| packages/serverless-workflow-diagram-editor/src/react-flow/diagram/Diagram.css | Adds styling for task leaf nodes and tweaks dark mode/custom node styling. |
| packages/serverless-workflow-diagram-editor/src/core/autoLayout.ts | Adjusts default node size to match the new node design. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
lornakelly
force-pushed
the
lk/85/leaf-node-styling
branch
from
e0b6903 to
83e4f3e
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
lornakelly
force-pushed
the
lk/85/leaf-node-styling
branch
from
83e4f3e to
35f5cee
Compare
lornakelly
force-pushed
the
lk/85/leaf-node-styling
branch
from
35f5cee to
65182ca
Compare
Signed-off-by: lornakelly <lornakelly88@gmail.com>
lornakelly
force-pushed
the
lk/85/leaf-node-styling
branch
from
65182ca to
b6c1020
Compare
Contributor
Author
|
After rebase with edge changes 
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #85
Summary
Add styled component for custom react flow leaf nodes (Call, Emit, Listen, raise, Run, Set, Switch, Wait)
Changes
TaskNodeContentcomponentScreen.Recording.2026-05-05.at.12.28.17.mov