fix(unix): prevent close/drain hangs after write timeouts#237
Open
dcodeIO wants to merge 2 commits intoserialport:mainfrom
Open
fix(unix): prevent close/drain hangs after write timeouts#237dcodeIO wants to merge 2 commits intoserialport:mainfrom
dcodeIO wants to merge 2 commits intoserialport:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While working with #235 (in WSL), I noticed that the Unix serial port implementation could hang on close/drain timeout paths, leaving the process alive after final output.
Particularly, the close path is hardened by setting
O_NONBLOCK, flushing pending TX (tcflush(..., TCOFLUSH)), and then closing the fd. This avoids blocking close behavior after prior write timeouts.The Linux drain path is made close-aware:
DrainBatonnow checksTIOCOUTQand exits early when close is in progress, rather than continuing to wait in timeout-heavy scenarios.Close intent is now marked at
Close(...)API entry (before queueing the close worker), so in-flight drain workers can observe cancellation immediately. This removes a race where worker-pool saturation could delay close and leave timeout-path runs hanging.Repros:
I also tested equivalent timeout paths on Windows and did not reproduce a similar close/drain lingering issue. I did observe a post-close "GetOverlappedResult: Operation aborted" error event there, but this appears to be separate platform-specific behavior.