fix: script injection in element locators with parameterized scripts#477
Open
Dor-bl wants to merge 1 commit into
Open
fix: script injection in element locators with parameterized scripts#477Dor-bl wants to merge 1 commit into
Dor-bl wants to merge 1 commit into
Conversation
Direct string interpolation was used to construct scripts for `execute_script`. This was replaced with parameterized scripts using `arguments[0]`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors the way JavaScript is executed in the element finding methods to improve security and maintainability. The main change is replacing string interpolation in JavaScript execution with the use of argument passing. This helps prevent potential injection issues and makes the code more robust.
JavaScript execution improvements:
_find_by_dommethod to useeval(arguments[0])with argument passing instead of directly interpolating the criteria into the JavaScript string._find_by_sizzle_selectormethod to usejQuery(arguments[0]).get()and pass the criteria as an argument, rather than interpolating it into the JavaScript string.application.execute_scriptin_find_by_sizzle_selectorto pass the criteria as an argument.