[CLNP-8095] feat: Add preferredAssetRepresentationMode option to createExpoFileService#285
Merged
OnestarLee merged 2 commits intomainfrom Feb 5, 2026
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #285 +/- ##
==========================================
- Coverage 10.88% 10.87% -0.01%
==========================================
Files 360 360
Lines 9053 9054 +1
Branches 2558 2438 -120
==========================================
Hits 985 985
- Misses 7992 8068 +76
+ Partials 76 1 -75 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
bang9
approved these changes
Feb 3, 2026
Collaborator
bang9
left a comment
There was a problem hiding this comment.
react-native-image-picker에서도assetRepresentationMode로 동일한 기능 제공하더라구요! 요고도 추가해 놓으면 좋을 것 같습니다.- 기존에는 HEIC/HEIF 를 아예 파일로 취급을 했던지라 (UIKit 플랫폼 호환성 때문에), 옵션을 주는거보다 아예 기본값을 호환성 높은 포멧으로 변환해주는 compatible 로 주는건 어떨까요?
- 제가 최근에 heic/heif 에서 mime type 이 안들어간다는 버그를 수정하면서, heic/heif 가 이미지로 취급이 되기 시작한 것 같습니다. 요고에 대한 수정도 #286 에 만들어두었습니다!
3cd322d to
c120369
Compare
Collaborator
Author
|
기존에 추가한 option 삭제하고 react-native-image-picker 포함하여 compatible 로 수정하였습니다 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For Internal Contributors
CLNP-8095
Description Of Changes
ExpoFileServiceOptionstype withimagePicker.preferredAssetRepresentationModeoptionpreferredAssetRepresentationModetolaunchCameraAsyncandlaunchImageLibraryAsynccallsautomatic(default),compatible(convert HEIC/HEVC to JPEG/H.264), andcurrent(keep original format)Background
In expo-image-picker v17.0.0, the default for
preferredAssetRepresentationModechanged from.automaticto.current:This change exposes the option to UIKit users so they can control the behavior based on their needs.
Types Of Changes
What types of changes does your code introduce to this project?
Put an
xin the boxes that apply