Skip to content

gapbind14: unconditionally call __builtin_unreachable#1150

Merged
Joseph-Edwards merged 2 commits intosemigroups:stable-5.6from
james-d-mitchell:tweak-unreachable
Mar 18, 2026
Merged

gapbind14: unconditionally call __builtin_unreachable#1150
Joseph-Edwards merged 2 commits intosemigroups:stable-5.6from
james-d-mitchell:tweak-unreachable

Conversation

@james-d-mitchell
Copy link
Collaborator

This change resolves the compiler warnings from the previous version of the code:

gapbind14/include/gapbind14/cpp_fn.hpp:42:3: warning: function declared 'noreturn' should not return [-Winvalid-noreturn]
   42 |   }

when compiling with clang. It also stops gapbind14 from depending on the Semigroups package at all (by removing the include of the config.hpp file).

We should probably update the build system to error out if __builtin_unreachable isn't present.

@Joseph-Edwards Joseph-Edwards merged commit 3610eeb into semigroups:stable-5.6 Mar 18, 2026
23 checks passed
@james-d-mitchell james-d-mitchell deleted the tweak-unreachable branch March 18, 2026 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants