Security: Argument Injection in git add command#555
Open
tomaioo wants to merge 1 commit into
Open
Conversation
In `lib/git.js`, the `add` function passes the `files` array directly into the `execa` arguments for `git add`. If a file path contains strings that start with `-` (e.g., `-u` or `--all`), `git` may interpret them as command-line options rather than file paths. This can lead to argument injection, potentially allowing unintended files to be staged or other git options to be triggered. Signed-off-by: tomaioo <203048277+tomaioo@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Security: Argument Injection in git add command
Problem
Severity:
High| File:lib/git.js:L26In
lib/git.js, theaddfunction passes thefilesarray directly into theexecaarguments forgit add. If a file path contains strings that start with-(e.g.,-uor--all),gitmay interpret them as command-line options rather than file paths. This can lead to argument injection, potentially allowing unintended files to be staged or other git options to be triggered.Solution
Prepend
--to the git arguments before the file list to explicitly mark the end of options and treat all subsequent arguments as file paths. For example:['add', '--force', '--ignore-errors', '--', ...files].Changes
lib/git.js(modified)