fix(harness): unique chain id for the major-upgrade suite too#447
Merged
Conversation
#446 wired runChainID into the load/release/chaos suites but missed TestChainUpgrade, which provisions a 4-validator chain on a static SEI_CHAIN_ID ("upg") and is therefore exposed to the same stale-genesis halt on any same-id collision (back-to-back run, or SIGKILL leaving genesis behind). Its own doc already calls SEI_CHAIN_ID "(base)"; this makes the code match. Completes the per-run unique chain id across all four suites. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
PR SummaryLow Risk Overview This avoids stale-genesis / same-id collisions when the upgrade harness runs back-to-back or leaves persisted genesis behind after an abrupt stop. Reviewed by Cursor Bugbot for commit 01056d1. Bugbot is set up for automated code reviews on this repo. Configure here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#446 wired
runChainIDinto the load/release/chaos suites but missedTestChainUpgrade— it provisions a 4-validator chain on a staticSEI_CHAIN_ID(upg), so it's exposed to the same stale-genesis halt on any same-id collision (back-to-back run, or a SIGKILL leaving genesis behind). It passed earlier only on a clean slate. Its own doc already callsSEI_CHAIN_ID"(base)"; this makes the code match.Completes the per-run unique chain id across all four suites (load/release/chaos already done in #446).
This is the identical one-line pattern #446's xreview ratified unanimously (sei-network dissenter held, idiomatic RATIFY).
go vet -tags integration+ gofmt clean. PLT-762 / PLT-758.