Skip to content

fix(harness): unique chain id for the major-upgrade suite too#447

Merged
bdchatham merged 1 commit into
mainfrom
fix/plt-762-upgrade-unique-chainid
Jun 24, 2026
Merged

fix(harness): unique chain id for the major-upgrade suite too#447
bdchatham merged 1 commit into
mainfrom
fix/plt-762-upgrade-unique-chainid

Conversation

@bdchatham

Copy link
Copy Markdown
Collaborator

#446 wired runChainID into the load/release/chaos suites but missed TestChainUpgrade — it provisions a 4-validator chain on a static SEI_CHAIN_ID (upg), so it's exposed to the same stale-genesis halt on any same-id collision (back-to-back run, or a SIGKILL leaving genesis behind). It passed earlier only on a clean slate. Its own doc already calls SEI_CHAIN_ID "(base)"; this makes the code match.

Completes the per-run unique chain id across all four suites (load/release/chaos already done in #446).

test/integration/upgrade_test.go:96  chainID := runChainID(mustEnv(t, "SEI_CHAIN_ID"))

This is the identical one-line pattern #446's xreview ratified unanimously (sei-network dissenter held, idiomatic RATIFY). go vet -tags integration + gofmt clean. PLT-762 / PLT-758.

#446 wired runChainID into the load/release/chaos suites but missed
TestChainUpgrade, which provisions a 4-validator chain on a static SEI_CHAIN_ID
("upg") and is therefore exposed to the same stale-genesis halt on any same-id
collision (back-to-back run, or SIGKILL leaving genesis behind). Its own doc
already calls SEI_CHAIN_ID "(base)"; this makes the code match. Completes the
per-run unique chain id across all four suites.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@cursor

cursor Bot commented Jun 24, 2026

Copy link
Copy Markdown

PR Summary

Low Risk
Single-line integration harness change with no production auth, data, or runtime logic touched.

Overview
TestChainUpgrade now derives the provisioned chain id via runChainID on the SEI_CHAIN_ID base env var, aligning with load/release/chaos suites from #446.

This avoids stale-genesis / same-id collisions when the upgrade harness runs back-to-back or leaves persisted genesis behind after an abrupt stop.

Reviewed by Cursor Bugbot for commit 01056d1. Bugbot is set up for automated code reviews on this repo. Configure here.

@bdchatham bdchatham merged commit 4c3c4f3 into main Jun 24, 2026
5 checks passed
@bdchatham bdchatham deleted the fix/plt-762-upgrade-unique-chainid branch June 24, 2026 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant