Skip to content

chore: remove seitask runner + Workflow scenarios (cutover)#442

Merged
bdchatham merged 5 commits into
mainfrom
cleanup/delete-seitask
Jun 23, 2026
Merged

chore: remove seitask runner + Workflow scenarios (cutover)#442
bdchatham merged 5 commits into
mainfrom
cleanup/delete-seitask

Conversation

@bdchatham

Copy link
Copy Markdown
Collaborator

What

The Go-native integration harness has replaced the seitask-runner + Chaos-Mesh Workflow nightly (harness CronJobs deployed in platform#1207). This deletes the legacy machinery — 7k lines removed:

  • cmd/seitask/, internal/seitask/, internal/runner/, internal/taskruntime/, runner/, scenarios/
  • the seitask image-build step in ecr.yml; the runner* Makefile targets + RUNNER_IMG
  • the committed xreview ledgers (process artifacts)

Survives: internal/keygen (general key derivation, used by TestRelease); the SeiNodeTask CRD + controller (now driven by the SDK's RunTask).

Safety

  • Verified no surviving package imports internal/seitask/internal/runner/internal/taskruntime (only comment mentions remain).
  • go build ./..., go vet ./..., go test ./..., and go test -c -tags integration ./test/integration/ all pass.
  • Companion platform PR removes the legacy nightly CronJobs/dirs + the sei/seitask-runner ECR repo + IAM.

🤖 Generated with Claude Code

The Go-native integration harness (test/integration, one CronJob per
target) has replaced the seitask-runner image + the Chaos-Mesh Workflow
nightly. Delete the legacy machinery:

- cmd/seitask/, internal/seitask/, internal/runner/, internal/taskruntime/,
  runner/ (the runner binary + its templates/RBAC), scenarios/ (the
  Workflow CR definitions).
- the seitask image-build step in ecr.yml; the runner/runner-image/
  runner-push Makefile targets + RUNNER_IMG (already stale paths).

internal/keygen survives (general derivation, used by TestRelease); the
SeiNodeTask CRD + its controller survive (driven by the SDK). go build,
vet, test, and the integration build tag all pass with no dangling refs.

Also drops the committed xreview ledgers (process artifacts, not code).

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@cursor

cursor Bot commented Jun 23, 2026

Copy link
Copy Markdown

PR Summary

Medium Risk
Large deletion of the old nightly path; safe if platform cutover and CronJobs already use integration-harness, but any remaining references to seitask-runner or Workflow YAML would break until cleaned up (e.g. .dockerignore still mentions runner/scenarios).

Overview
Removes the legacy seitask monolith (cmd/seitask, internal/seitask, internal/runner, internal/taskruntime), runner templates/RBAC, and Chaos Mesh Workflow scenario assets, now superseded by Go integration tests (test/integration, integration-harness image).

CI/build: Drops the sei/seitask-runner ECR build from .github/workflows/ecr.yml; Makefile loses runner / runner-image / runner-push and RUNNER_IMG.

RBAC/docs/CRD copy: Strips chaos-mesh.org workflows / workflownodes from manager roles; updates SeiNodeTask docs to describe fan-out via the orchestrating caller instead of seitask-runner; internal/keygen comments point at the integration harness for Secret wiring.

Kept: SeiNodeTask CRD + controller, internal/keygen, and nightly coverage via compiled integration tests and sdk/sei RunTask.

Reviewed by Cursor Bugbot for commit 1e3f5a8. Bugbot is set up for automated code reviews on this repo. Configure here.

bdchatham and others added 4 commits June 23, 2026 13:53
Drop the 'Go-native' framing and the 'replaces the Chaos-Mesh Workflow /
seitask-runner' narrative from doc comments (incl. now-dangling refs to
the deleted machinery); keep the technical rationale (chain-as-medium,
the env-alias superset the release-test image reads).

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Deleting internal/runner dropped its +kubebuilder:rbac markers for
chaos-mesh workflows/workflownodes, which controller-gen had aggregated
into the manager role. Regenerate so verify-generated passes; the manager
never used that access (it was the runner's).

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
…nery

Coral slate (k8s + idiom) on the deletion PR:

- The SeiNodeTask CRD type doc comments named the seitask-runner / Chaos
  Workflow layer as where to express fan-out — and the spec.target one
  shipped into the served CRD description (kubectl explain would cite
  deleted machinery). Re-point to "the orchestrating caller (one task per
  node)" and regenerate config/crd + manifests.
- Crisp the remaining dangling "scenario" / "scenarios/major-upgrade.yaml"
  references in upgrade_test.go + release_test.go (keep the technical
  rationale, drop the provenance trailers + the broken line-flow).

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Idiom + k8s confirmation pass follow-ups:
- Tidy the rewrapped TestChainUpgrade doc line-flow.
- Re-point CLAUDE.md's Ready/Failed-exception rationale off "the
  seitask-runner depends on kubectl wait" to "consumers wait on" (the
  contract is unchanged; the named consumer was deleted).
- Drop the deleted seitask from the SDK's consumer-naming comments
  (labels.go, readiness.go, render.go, sdk/CLAUDE.md) — seictl stays.
- gitignore the stray local seitask build artifact.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@bdchatham bdchatham merged commit 5730aa4 into main Jun 23, 2026
5 checks passed
@bdchatham bdchatham deleted the cleanup/delete-seitask branch June 23, 2026 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant