Remove live IBC transfer module - #3981
Conversation
Remove ICS-20 module wiring, APIs, CLI commands, and CosmWasm integration. Retire the live IBC precompile while preserving legacy implementations and codecs for historical tracing and transaction decoding. Keep the transfer store and module account mounted for historical state safety, and remove its module version during the v6.7 upgrade.
|
The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3981 +/- ##
==========================================
- Coverage 58.66% 57.61% -1.05%
==========================================
Files 2324 2226 -98
Lines 198757 187042 -11715
==========================================
- Hits 116600 107768 -8832
+ Misses 71407 69429 -1978
+ Partials 10750 9845 -905
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
PR SummaryHigh Risk Overview The transfer KV store, module account (minter/burner), and codecs stay mounted so historical state and Swagger/docs drop transfer query endpoints. README no longer claims native IBC token access. Reviewed by Cursor Bugbot for commit d3ca673. Bugbot is set up for automated code reviews on this repo. Configure here. |
| func (k Keeper) GetDenomTrace(ctx sdk.Context, denomTraceHash tmbytes.HexBytes) (types.DenomTrace, bool) { | ||
| store := prefix.NewStore(ctx.KVStore(k.storeKey), types.DenomTraceKey) |
There was a problem hiding this comment.
should we remove this too?
| txMsgIbcTransfer metric.Int64Gauge | ||
| ibcTransferSend metric.Int64Counter |
There was a problem hiding this comment.
curious why we want to keep these?
| ) | ||
|
|
||
| // GetSendEnabled retrieves the send enabled boolean from the paramstore | ||
| func (k Keeper) GetSendEnabled(ctx sdk.Context) bool { |
There was a problem hiding this comment.
can probably remove this too if we're removing the other getters for params
| default: | ||
| return nil, sdkerrors.Wrap(types.ErrUnknownMsg, "Unknown variant of IBC") | ||
| } | ||
| func EncodeIBCMsg(_ sdk.Context, sender sdk.AccAddress, _ string, msg *wasmvmtypes.IBCMsg) ([]sdk.Msg, error) { |
There was a problem hiding this comment.
woulnd't we want to remove all ibc messages?
3 participants
Remove ICS-20 module wiring, APIs, CLI commands, and CosmWasm integration.
Retire the live IBC precompile while preserving legacy implementations and codecs for historical tracing and transaction decoding. Keep the transfer store and module account mounted for historical state safety, and remove its module version during the v6.7 upgrade.