You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Low Risk
Observability-only change to metric name/label translation; no consensus, auth, or transaction logic affected.
Overview
Fixes Prometheus remote write dropping node metrics by configuring both OTel→Prometheus exporters to use UnderscoreEscapingWithSuffixes when translating OTel metric and label names.
SetupOtelPrometheus (sei-db/common/metrics/setup.go) and SetupOtelMetricsProvider (utils/metrics/metrics_util.go) now pass prometheus.WithTranslationStrategy(otlptranslator.UnderscoreEscapingWithSuffixes) (or the otel exporter equivalent). That rewrites invalid label characters—such as dots in OTel attributes—into Prometheus-safe names, which addresses fallout from the earlier sei-chain → sei_chain namespace change.
Reviewed by Cursor Bugbot for commit b68220b. Bugbot is set up for automated code reviews on this repo. Configure here.
@philipsu522 this would be great to get into 6.6 release if possible
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After the
sei-chaintosei_chainprefix change in #3554, it surfaced that otel labels also had invalid Prometheus label characters ('.')Tested on local Sei node, with this patch the Prometheus remote write endpoint no longer drops any metrics from the node.
Example before:
after: