Skip to content

chore(evmrpc): eth_getBlockReceipts not-found behavior parity#3068

Open
mojtaba-esk wants to merge 1 commit intomojtaba/evmrpc-return-null-for-unknown/empty-block-hashfrom
mojtaba/fix-eth_getBlockReceipts-not-found-behavior-parity
Open

chore(evmrpc): eth_getBlockReceipts not-found behavior parity#3068
mojtaba-esk wants to merge 1 commit intomojtaba/evmrpc-return-null-for-unknown/empty-block-hashfrom
mojtaba/fix-eth_getBlockReceipts-not-found-behavior-parity

Conversation

@mojtaba-esk
Copy link
Contributor

Describe your changes and provide context

Closes PLT-163

Ref PLT-163

Testing performed to validate your change

=== RUN   TestEVMRPCSpec/eth_getBlockReceipts/get-block-receipts-empty.iox
    rpc_io_test.go:79: [DEBUG] SEI_EVM_IO_SEED_BLOCK=""
    rpc_io_test.go:114: [DEBUG] pair 1: placeholders=[] bindings=map[]
    rpc_io_test.go:129: [DEBUG] pair 1: request {"jsonrpc":"2.0","id":1,"method":"eth_getBlockReceipts","params":["0x0000000000000000000000000000000000000000000000000000000000000000"]}
    rpc_io_test.go:144: [DEBUG] pair 1: bindings after apply: map[]
=== RUN   TestEVMRPCSpec/eth_getBlockReceipts/get-block-receipts-not-found.iox
    rpc_io_test.go:79: [DEBUG] SEI_EVM_IO_SEED_BLOCK=""
    rpc_io_test.go:114: [DEBUG] pair 1: placeholders=[] bindings=map[]
    rpc_io_test.go:129: [DEBUG] pair 1: request {"jsonrpc":"2.0","id":1,"method":"eth_getBlockReceipts","params":["0x00000000000000000000000000000000000000000000000000000000deadbeef"]}
    rpc_io_test.go:144: [DEBUG] pair 1: bindings after apply: map[]
--- PASS: TestEVMRPCSpec (0.00s)
    --- PASS: TestEVMRPCSpec/eth_getBlockReceipts/get-block-receipts-empty.iox (0.00s)
    --- PASS: TestEVMRPCSpec/eth_getBlockReceipts/get-block-receipts-not-found.iox (0.00s)

@github-actions
Copy link

github-actions bot commented Mar 13, 2026

The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed✅ passedMar 13, 2026, 1:13 PM

@codecov
Copy link

codecov bot commented Mar 13, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 58.59%. Comparing base (e4f1ad1) to head (0456217).

Additional details and impacted files

Impacted file tree graph

@@                                   Coverage Diff                                    @@
##           mojtaba/evmrpc-return-null-for-unknown/empty-block-hash    #3068   +/-   ##
========================================================================================
  Coverage                                                    58.58%   58.59%           
========================================================================================
  Files                                                         2080     2080           
  Lines                                                       171660   171664    +4     
========================================================================================
+ Hits                                                        100573   100579    +6     
+ Misses                                                       62165    62164    -1     
+ Partials                                                      8922     8921    -1     
Flag Coverage Δ
sei-chain-pr 67.33% <100.00%> (+0.08%) ⬆️
sei-db 70.41% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
evmrpc/block.go 76.71% <100.00%> (+0.32%) ⬆️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Collaborator

@masih masih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Easy peasy 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants