You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 43.32%. Comparing base (1952adf) to head (8e136a1). ⚠️ Report is 1 commits behind head on tony/v6.3.
❌ Your patch status has failed because the patch coverage (0.00%) is below the target coverage (70.00%). You can increase the patch coverage or adjust the target coverage.
❌ Your project status has failed because the head coverage (38.19%) is below the target coverage (40.00%). You can increase the head coverage or adjust the target coverage.
The reason will be displayed to describe this comment to others. Learn more.
Beyond a scope of this PR and a prexisting pattern: I have raised this issue in previous reviews: if we ever hit double digits major/minor strings.Compare will become incorrect since it sorts lexicographically.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes and provide context
We will disallow unsafe tx starting v6.3.0, but unsafe txs that were sent before v6.3.0 should still be traceable
Testing performed to validate your change
tested on rpc node