Skip to content

ci: add CI workflow for release-1.3#85

Open
kdacosta0 wants to merge 1 commit into
release-1.3from
ci/add-workflows-release-1.3
Open

ci: add CI workflow for release-1.3#85
kdacosta0 wants to merge 1 commit into
release-1.3from
ci/add-workflows-release-1.3

Conversation

@kdacosta0

@kdacosta0 kdacosta0 commented Jul 14, 2026

Copy link
Copy Markdown
Member

Summary

Backport ci.yml (lint + unit tests) from main so that PRs targeting release branches get CI coverage. Without this, PRs merged with no checks (as seen with PR #84).

Changes from main:

  • ci.yml: golangci-lint pinned to v1.64.8 (release branches use v1 config format)
  • .golangci.yml: disable errname, intrange, perfsprint and exclude gosec G115 (not enabled on main v2 config either)

Note: e2e.yml not included — the operator on release-1.3 fails to start in Kind with no matches for kind "Ingress" in version "config.openshift.io/v1" (requires OpenShift-specific CRDs not available in Kind).

Test plan

  • CI workflow self-triggers on this PR
  • Lint passes with v1 config
  • Unit tests pass

🤖 Generated with Claude Code

@qodo-for-securesign

qodo-for-securesign Bot commented Jul 14, 2026

Copy link
Copy Markdown

Code Review by Qodo

Grey Divider

Sorry, something went wrong

We weren't able to complete the code review on our side. Please try again

Grey Divider

Qodo Logo

@kdacosta0
kdacosta0 force-pushed the ci/add-workflows-release-1.3 branch 3 times, most recently from f67390a to 8d4113c Compare July 14, 2026 13:40
@qodo-for-securesign

Copy link
Copy Markdown

PR Summary by Qodo

ci: backport CI and E2E workflows to release-1.3

⚙️ Configuration changes 🕐 Less than 10 minutes

Grey Divider

AI Description

• Adds ci.yml (lint + unit tests) and e2e.yml (full E2E) GitHub Actions workflows, backported
 from main.
• Fixes the gap where PRs targeting release branches previously got no CI coverage.
• Pins golangci-lint to v1.55.2 to match the v1 config format used on release branches.
• Defaults OPERATOR_REF to release-1.3 for the E2E workflow's operator checkout.
Diagram

graph TD
  A([PR / Push Event]) --> B{Target Branch}
  B --> C[[ci.yml]]
  B --> D[[e2e.yml]]
  C --> E[Lint golangci-lint v1.55.2]
  C --> F[Unit Tests go test]
  D --> G[Checkout operator release-1.3]
  D --> H[Kind Cluster + Deploy Operator]
  H --> I[Run E2E Tests]

  subgraph Legend
    direction LR
    _wf[[Workflow]] ~~~ _step[Step/Job] ~~~ _ev([Event])
  end
Loading
High-Level Assessment

Backporting the existing main-branch workflows with minimal, targeted adjustments (lint version pin, default operator ref) is the correct and lowest-risk approach for restoring CI coverage on the release branch; no alternative architecture is warranted for this change.

Files changed (2) +192 / -0

Other (2) +192 / -0
ci.ymlAdd CI workflow with lint and unit test jobs +44/-0

Add CI workflow with lint and unit test jobs

• New GitHub Actions workflow that runs golangci-lint (pinned to v1.55.2 for v1 config compatibility) and Go unit tests on pull requests and pushes to main/release branches.

.github/workflows/ci.yml

e2e.ymlAdd E2E workflow defaulting to release-1.3 operator ref +148/-0

Add E2E workflow defaulting to release-1.3 operator ref

• New GitHub Actions workflow that provisions a Kind cluster, deploys the operator, installs SecureSign, and runs the full E2E test suite; defaults OPERATOR_REF to release-1.3 and supports manual dispatch overrides.

.github/workflows/e2e.yml

Backport ci.yml from main so that PRs targeting release branches
get lint and unit test coverage. Without this, PRs merged with
no checks (as seen with PR #84).

Changes from main:
- ci.yml: golangci-lint pinned to v1.64.8 (v1 config format on this branch)
- .golangci.yml: disable errname, intrange, perfsprint and exclude
  gosec G115 (not enabled on main v2 config either)

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@kdacosta0
kdacosta0 force-pushed the ci/add-workflows-release-1.3 branch from 8d4113c to 9a9ce3f Compare July 14, 2026 14:00
@kdacosta0 kdacosta0 changed the title ci: add CI and E2E workflows for release-1.3 ci: add CI workflow for release-1.3 Jul 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant