Add TCPCLv4 message definitions and tcp_reassemble interface - #5076
Draft
BrianSipos wants to merge 1 commit into
Draft
Add TCPCLv4 message definitions and tcp_reassemble interface#5076BrianSipos wants to merge 1 commit into
BrianSipos wants to merge 1 commit into
Conversation
BrianSipos
commented
Aug 7, 2026
| return conf.raw_layer | ||
|
|
||
|
|
||
| class ContactV3(_BaseContact): |
Author
There was a problem hiding this comment.
Is it preferred that all public classes use a globally-unique prefix for user experience consistency?
Member
There was a problem hiding this comment.
If possible yeah, it allows to avoid conflicts. It's up to you to use TCPCL_Contact or TCPCLContact, or some other method :)
It also helps when auto-completing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is a port of earlier TCPCL packet definitions from dtn-demo-agent with more modern scapy-friendly patterns of dispatchers and with a
tcp_reassemble()interface.This is an alternative to part of #4824 with some simplified structures.
Test capture files are included for demonstration.