pfroute: parse routing messages on NetBSD correctly - #5073
Draft
evverx wants to merge 3 commits into
Draft
Conversation
NetBSD switched to 64-bit time_t in https://www.netbsd.org/releases/formal-6/NetBSD-6.0.html so the size of struct timespec is (8+4) bytes. Closes: secdev#5054 AI-Assisted: no
NetBSD switched to uint64_t in NetBSD/src@23cb540 to make the routing socket interface act identically for both 32 and 64 bit programs. AI-Assisted: no
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #5073 +/- ##
==========================================
- Coverage 80.50% 79.70% -0.81%
==========================================
Files 390 372 -18
Lines 96785 96487 -298
==========================================
- Hits 77920 76908 -1012
- Misses 18865 19579 +714
🚀 New features to boost your workflow:
|
evverx
force-pushed
the
netbsd-followups
branch
from
August 3, 2026 14:22
6adb309 to
7a49dce
Compare
AI-Assisted: no
evverx
force-pushed
the
netbsd-followups
branch
from
August 3, 2026 14:54
7a49dce to
00a3ba4
Compare
evverx
commented
Aug 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pfroute: adjust the size of ifi_lastchange on NetBSD
NetBSD switched to 64-bit time_t in
https://www.netbsd.org/releases/formal-6/NetBSD-6.0.html so the size of
struct timespec is (8+4) bytes.
Closes: #5054
pfroute: round up sockaddrs on NetBSD correctly
NetBSD switched to uint64_t in
NetBSD/src@23cb540
to make the routing socket interface act identically for both 32 and 64
bit programs.
It's a draft because it needs tests and more testing in general but with this PR applied scapy no longer fails to start,
conf.ifacesandconf.routelook correct,conf.route.routeno longer complains about the missing default route and so on.