Skip to content

ci: drop downstream import check#4988

Open
evverx wants to merge 1 commit intosecdev:masterfrom
evverx:trim-import-check
Open

ci: drop downstream import check#4988
evverx wants to merge 1 commit intosecdev:masterfrom
evverx:trim-import-check

Conversation

@evverx
Copy link
Copy Markdown
Contributor

@evverx evverx commented May 5, 2026

to prevent it from interfering with the upstream CI.

The import check was added recently in
https://src.fedoraproject.org/rpms/scapy/c/878585466261f17c01516a653d19cf47022c2f9f?branch=rawhide and it started failing when #4975 was merged with

ModuleNotFoundError: No module named 'winreg'
+ /usr/bin/python3 -sP /usr/lib/rpm/redhat/import_all_modules.py \
  -f /builddir/build/BUILD/scapy-2.7.0-build/scapy-2.7.0-1.20260423030854887593.pr2.57.g5d1727ff.fc43.x86_64-pyproject-modules \
  -e scapy.arch.bpf.core -e scapy.arch.bpf.supersocket -e scapy.arch.windows \
  -e scapy.arch.windows.native -e scapy.arch.windows.structures \
  -e scapy.contrib.cansocket_python_can -e scapy.tools.generate_bluetooth \
  -e scapy.tools.generate_ethertypes -e scapy.tools.generate_manuf \
  -e scapy.tools.scapy_pyannotate -e scapy.libs.winpcapy
...
Check import: scapy.arch.windows.sspi
Traceback (most recent call last):
  File "/usr/lib/rpm/redhat/import_all_modules.py", line 106, in import_modules
    importlib.import_module(module)
    ~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^
  File "/usr/lib64/python3.14/importlib/__init__.py", line 88, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
           ~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
...
  File "/builddir/build/BUILD/scapy-2.7.0-build/BUILDROOT/usr/lib/python3.14/site-packages/scapy/arch/windows/__init__.py", line 18, in <module>
    import winreg
ModuleNotFoundError: No module named 'winreg'

Since it can't keep up with upstream PRs it can be trimmed.

Big endian builds are back to normal
(https://forge.fedoraproject.org/infra/ansible/pulls/3316) and left intact.

Closes #4979

It was tested in https://copr.fedorainfracloud.org/coprs/packit/evverx-scapy-2/build/10426205/

Checklist :

  • If you are new to Scapy: I have checked CONTRIBUTING.md (esp. section submitting-pull-requests)
  • I squashed commits belonging together
  • I added unit tests or explained why they are not relevant
  • I executed the regression tests (using tox)
  • If the PR is still not finished, please create a Draft Pull Request
  • This PR uses (partially) AI-generated code. If so:
    • I ensured the generated code follows the internal concepts of scapy
    • This PR has a test coverage > 90%
    • I reviewed every generated line
    • If this PR contains more than 500 lines of code (excluding unit tests) I considered splitting this PR.
    • I considered interoperability tests with existing packages or utilities to ensure conformity of a newly generated protocol

I understand that failing to mention the use of AI may result in a ban. (We do not forbid it, but you must play fair. Be warned !)

fixes #4979

to prevent it from interfering with the upstream CI.

The import check was added recently in
https://src.fedoraproject.org/rpms/scapy/c/878585466261f17c01516a653d19cf47022c2f9f?branch=rawhide
and it started failing when secdev#4975
was merged with
```
+ /usr/bin/python3 -sP /usr/lib/rpm/redhat/import_all_modules.py \
  -f /builddir/build/BUILD/scapy-2.7.0-build/scapy-2.7.0-1.20260423030854887593.pr2.57.g5d1727ff.fc43.x86_64-pyproject-modules \
  -e scapy.arch.bpf.core -e scapy.arch.bpf.supersocket -e scapy.arch.windows \
  -e scapy.arch.windows.native -e scapy.arch.windows.structures \
  -e scapy.contrib.cansocket_python_can -e scapy.tools.generate_bluetooth \
  -e scapy.tools.generate_ethertypes -e scapy.tools.generate_manuf \
  -e scapy.tools.scapy_pyannotate -e scapy.libs.winpcapy
...
...
  File "/builddir/build/BUILD/scapy-2.7.0-build/BUILDROOT/usr/lib/python3.14/site-packages/scapy/arch/windows/__init__.py", line 18, in <module>
    import winreg
ModuleNotFoundError: No module named 'winreg'
```
Since it can't keep up with upstream PRs it can be trimmed.

Big endian builds are back to normal
(https://forge.fedoraproject.org/infra/ansible/pulls/3316) and left
intact.

Closes secdev#4979
@evverx evverx force-pushed the trim-import-check branch from 3e14372 to 680e863 Compare May 5, 2026 14:19
@codecov
Copy link
Copy Markdown

codecov Bot commented May 5, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.28%. Comparing base (8c5a9a8) to head (680e863).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4988   +/-   ##
=======================================
  Coverage   80.28%   80.28%           
=======================================
  Files         383      383           
  Lines       94703    94703           
=======================================
+ Hits        76031    76032    +1     
+ Misses      18672    18671    -1     

see 7 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tests fail on Packit

1 participant