Skip to content

Fix NTP Authenticator parsing for non-MD5 digest types #4918

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 8 commits into
base: master
Choose a base branch
from
+48 −25

Remove unused constants, fix formatting, and simplify NTPAuthenticator

bcfda21
Select commit
Loading
Failed to load commit list.
Draft

Fix NTP Authenticator parsing for non-MD5 digest types #4918

Remove unused constants, fix formatting, and simplify NTPAuthenticator
bcfda21
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Feb 20, 2026 in 0s

80.63% (+0.53%) compared to ded1d73

View this Pull Request on Codecov

80.63% (+0.53%) compared to ded1d73

Details

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.63%. Comparing base (ded1d73) to head (bcfda21).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #4918      +/-   ##
==========================================
+ Coverage   80.10%   80.63%   +0.53%     
==========================================
  Files         370      370              
  Lines       91727    91723       -4     
==========================================
+ Hits        73477    73965     +488     
+ Misses      18250    17758     -492
Files with missing lines Coverage Δ
scapy/layers/ntp.py 87.26% <100.00%> (-0.40%) ⬇️

... and 22 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
View more details on Codecov