More Bluetooth 5.0+ packets

[sacca97]

Introduces various stuff from Bluetooth 5.0+ plus some standardized field naming across packets for clarity and interoperability. Additionally covers an edge case in the HCI command handling.

What was added:

• HCI_LE_Meta_Enhanced_Connection_Complete
• HCI_Cmd_LE_Set_Extended_Advertising_Parameters
• HCI_Cmd_LE_Set_Extended_Advertising_Data
• HCI_Cmd_LE_Set_Advertising_Set_Random_Address
• HCI_Cmd_LE_Set_Extended_Scan_Parameters
• HCI_Cmd_LE_Set_Extended_Scan_Enable
• HCI_Cmd_LE_Extended_Create_Connection
• HCI_Cmd_LE_Set_Event_Mask (update 8-byte bitmask)

What was modified:

• atype / oatype / datype --> own_addr_type, peer_addr_type, or addr_type.
• address / paddr / daddr --> addr or peer_addr
• HCI receive now checks r.code in (0x0e, 0x0f) to cope with commands such as "Create Connection" which is async and returns a "Pending" status.

I also added and executed the tests in bluetooth.uts

[polydroi]

Thanks for your pr. could you please revert all changes introduced from your code formatter.

[sacca97]

@polydroi sorry for that, should be good now

[sacca97]

Added relevant tests to bluetooth.uts

I did not add tests for, e.g., HCI_Cmd_LE_Set_Extended_Scan_Parameters, as the original version did not have them either.

[polybassa]

What is the reason for all the name changes. Are the old names incorrect?

The change of a field name might break existing applications.

[sacca97]

@polybassa, the latest versions of the standard refer to these fields as *_address or *_address_type. I changed them because in Scapy, some packets used the standard terminology, while others did not. So it is mostly about coherence across all packets, but yes, the "correct" field name would be the longer one.

We can also stick with atype, patype, ... for all I care, as long as all packets use the same names. If this is the preferred direction I can update the PR, but it will still break some existing applications probably.

[gpotter2]

Could you use

scapy/scapy/packet.py

Line 109 in ed0707e

deprecated_fields = {} # type: Dict[str, Tuple[str, str]]

to make the old fields redirect to the new ones ? You'll find many examples in the rest of Scapy.

Thanks !