Open
Conversation
seanhandley
approved these changes
Sep 18, 2025
Owner
seanhandley
left a comment
seanhandley
left a comment
There was a problem hiding this comment.
Thanks @bschrag620
Happy to merge this, but I'm unlikely to put out a patch release as I'm not actively working on this library any more.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello @seanhandley
Came across what seems to be a bug. When calling
H3.linefor two points that are far enough apart such that a line can't be created, theline_sizecall returns -1. This is then passed intoBindings::Private.h3_linewhere a pointer is then initialized with a size of -1. This causes anNoMemoryError: too large allocation size. This can be guarded by returning earlier in the cycle if line_size returns a negative value.