tool: avoid --release for development and fix unsigned overflow#490
Merged
Conversation
This has not been an issue in the past since we always build the tool in release mode so the Rust compiler was not doing overflow checks. Since the kernel headers use the constants, and we're trying to follow what the kernel does, use them as well rather than doing the calculation. Signed-off-by: Ivan Velickovic <i.velickovic@unsw.edu.au>
This script is for developing, so it makes more sense that we have all the Rust debug checks available. Signed-off-by: Ivan Velickovic <i.velickovic@unsw.edu.au>
Ivan-Velickovic
force-pushed
the
debug_tool
branch
from
e29915d to
47f472c
Compare
midnightveil
approved these changes
May 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See commit messages for details.