Stabilize sliding-window cache test across transformers cache aliases#428
Draft
Copilot wants to merge 2 commits into
Draft
Stabilize sliding-window cache test across transformers cache aliases#428Copilot wants to merge 2 commits into
Copilot wants to merge 2 commits into
Conversation
Open
Agent-Logs-Url: https://github.com/sdpython/onnx-diagnostic/sessions/8c07d019-c51a-4d37-b87f-4b3d4b0df475 Co-authored-by: xadupre <22452781+xadupre@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix test issue in caching helper tests
Stabilize sliding-window cache test across transformers cache aliases
May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test_make_sliding_window_cachewas failing because newertransformersversions aliasSlidingWindowCachetoStaticCache, while the test expected a hardcoded class name. This PR makes the assertion resilient to that API evolution without weakening cache shape/value validation.Test expectation update (runtime cache class name)
_unittests/ut_helpers/test_cache_helper.py, changed the expected string prefix from a fixedSlidingWindowCacheliteral totype(cache).__name__.Scope
test_make_sliding_window_cache.