Upgrade to Rust 2021#41
Open
stefnotch wants to merge 2 commits intosdleffler:masterfrom
Open
Conversation
Owner
|
Hi! Thank you for your work. I recognize I've been putting off dealing with some outstanding PRs on this repo for quite a while now - I'll try to take a look at this tomorrow. |
Author
|
Thank you! I appreciate it. If there's anything I could do to make it easier for you, do let me know. I'll happily change code, write unit tests, benchmarks, etc. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This lets us get rid of unreachable = "1.0.0" in favour of the standard library https://doc.rust-lang.org/core/option/enum.Option.html#method.unwrap_unchecked