tests: fix NLB replacement test bootstrap crash due to missing rackdc properties#772
Open
mykaul wants to merge 1 commit intoscylladb:masterfrom
Open
tests: fix NLB replacement test bootstrap crash due to missing rackdc properties#772mykaul wants to merge 1 commit intoscylladb:masterfrom
mykaul wants to merge 1 commit intoscylladb:masterfrom
Conversation
… properties The _bootstrap_node() method in TestFullNodeReplacementThroughNlb calls ccm_cluster.add() without passing data_center or rack. CCM does not infer these from existing nodes, so the new node's cassandra-rackdc.properties file is left with only template comments. Scylla's GossipingPropertyFileSnitch fails to parse the empty file and crashes on startup with 'locator::bad_property_file_error'. Fix by reading data_center/rack from an existing cluster node and passing them explicitly to ccm_cluster.add(). This test was added in PR scylladb#706 with a @skip_scylla_version_lt(2026.1.0) decorator and CI runs Scylla 2025.2, so the bug was never caught.
Collaborator
|
@mykaul , this fix is wrong - test needs to specify concrete dc and rack it wants to place new nodes in, taking them from nodes already provisioned |
Author
@dkropachev - isn't it correct anyway, to specify the topology explicitly? I can fix the test in addition, but this seems correct as well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TestFullNodeReplacementThroughNlb::test_should_survive_full_node_replacement_through_nlbwhich always crashes when bootstrapping node 4/5_bootstrap_node()callsccm_cluster.add()withoutdata_centerorrack— CCM leavescassandra-rackdc.propertiesempty, and Scylla's snitch crashes withlocator::bad_property_file_errordata_center/rackfrom existing cluster nodes and pass explicitlyDetails
The test was added in PR #706 with
@skip_scylla_version_lt(scylla_version="2026.1.0"). Since CI usesSCYLLA_VERSION: release:2025.2, the test was always skipped and the bug was never caught.Scylla error from node4 startup log:
Testing
Verified 10/10 passes on Scylla 2026.1 after the fix (previously 0/10).