perf: use pre-allocated constant for null sentinel in collection serialization#763
Draft
mykaul wants to merge 1 commit intoscylladb:masterfrom
Draft
perf: use pre-allocated constant for null sentinel in collection serialization#763mykaul wants to merge 1 commit intoscylladb:masterfrom
mykaul wants to merge 1 commit intoscylladb:masterfrom
Conversation
…alization Replace per-call int32_pack(-1) with a module-level _INT32_NULL constant in serialize methods of ListType, SetType, MapType, TupleType, and UserType. This avoids a struct.pack call on every null element during collection serialization. Affected sites: - _SimpleParameterizedType.serialize_safe (ListType/SetType) - MapType.serialize_safe (null key + null value) - TupleType.serialize_safe - UserType.serialize_safe
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
int32_pack(-1)with a module-level_INT32_NULLconstant in 5 collection serialize methodsstruct.pack()call on every null element during collection serializationDetails
The CQL protocol represents
nullcollection elements as a 4-byteint32with value-1. Previously, every null element triggered a freshstruct.pack('>i', -1)call. This PR pre-computes the result once at module load time and reuses thebytesobject.Affected sites
ListType/SetType_SimpleParameterizedType.serialize_safeMapTypeMapType.serialize_safeTupleTypeTupleType.serialize_safeUserTypeUserType.serialize_safeBenchmark results
Isolated write operation (the
buf.write(...)call itself):buf.write(int32_pack(-1))(before)buf.write(_INT32_NULL)(after)End-to-end
ListType.serialize(list with 50% null elements):TupleType.serialize(5-element tuple, all nulls):Testing
CollectionNullSentinelTestswith 5 round-trip tests covering List, Set, Map, Tuple, and UserType withNoneelements