Remove scales dependency with self-contained metrics implementation #681
+769
−70
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
dkropachev
force-pushed
the
remove-scales-dependency
branch
2 times, most recently
from
d2d6b18 to
9e60f4e
Compare
The scales library had its last release in 2015 and was only tested on Python 2.7/3.3. This change replaces it with a self-contained metrics implementation that provides the same functionality: - IntStat: Thread-safe integer counter - PmfStat: Percentile/distribution statistics with reservoir sampling - Stat: Gauge statistics with callable evaluation - StatsCollection: Named collections of statistics - Global registry for metrics access via getStats() The new implementation maintains API compatibility with the existing metrics interface used by the driver. Fixes #665
- Add comparison operators (__eq__, __ne__, __lt__, __le__, __gt__, __ge__) to IntStat class for direct comparison with integers - Add __hash__ method to IntStat for use in sets/dicts - Add Metrics.shutdown() method to remove stats from global registry - Call metrics.shutdown() from Cluster.shutdown() to prevent stale weakref errors when accessing getStats() after cluster shutdown - Fix test using 'is' instead of '==' for IntStat comparison - Add unit tests for new comparison operators and shutdown functionality
dkropachev
force-pushed
the
remove-scales-dependency
branch
from
9e60f4e to
70d218b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The
scaleslibrary had its last release in 2015 and was only tested on Python 2.7/3.3. This change replaces it with a self-contained metrics implementation that provides the same functionality:IntStat: Thread-safe integer counterPmfStat: Percentile/distribution statistics with reservoir samplingStat: Gauge statistics with callable evaluationStatsCollection: Named collections of statisticsgetStats()The new implementation maintains API compatibility with the existing metrics interface used by the driver.
Test plan
Fixes #665