Skip to content

Update guava monorepo#703

Open
dkropachev wants to merge 2 commits intoscylladb:scylla-4.xfrom
dkropachev:dk/guava-monorepo
Open

Update guava monorepo#703
dkropachev wants to merge 2 commits intoscylladb:scylla-4.xfrom
dkropachev:dk/guava-monorepo

Conversation

@dkropachev
Copy link

@dkropachev dkropachev commented Oct 4, 2025

Update guava to 33.5.0 and fix test regression.

```
com.datastax.oss.driver.internal.core.metadata.token.NetworkTopologyReplicationStrategyTest.should_abort_early_and_log_when_bad_replication_factor_cannot_be_met -- Time elapsed: 0.007 s <<< ERROR!
org.mockito.exceptions.base.MockitoException:

Cannot mock/spy class com.datastax.oss.driver.shaded.guava.common.collect.RegularImmutableList
Mockito cannot mock/spy because :
 - final class
	at com.datastax.oss.driver.internal.core.metadata.token.NetworkTopologyReplicationStrategyTest.countTraversedTokens(NetworkTopologyReplicationStrategyTest.java:658)
	at com.datastax.oss.driver.internal.core.metadata.token.NetworkTopologyReplicationStrategyTest.should_abort_early_and_log_when_bad_replication_factor_cannot_be_met(NetworkTopologyReplicationStrategyTest.java:631)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)
```
Copy link

@Bouncheck Bouncheck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (outside of test failures)

@Bouncheck
Copy link

Bouncheck commented Oct 6, 2025

The failures with Scylla look unrelated, but the Cassandra job looks weird.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants