Skip to content

refactor: clean up invalid log tags (#426) #684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
akkicodes-dev wants to merge 1 commit into
base: main
Choose a base branch
from
+10 −5
Open

refactor: clean up invalid log tags (#426) #684

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion app/src/main/java/be/scri/helpers/KeyboardBase.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,7 @@ class KeyboardBase {
* Constants for keyboard layouts and the function to retrieve them.
*/
companion object {
private const val TAG = "KeyboardBase"
private const val TAG_KEYBOARD = "Keyboard"
private const val TAG_ROW = "Row"
private const val TAG_KEY = "Key"
Expand Down Expand Up @@ -221,7 +222,7 @@ class KeyboardBase {
else -> res.getDimension(R.dimen.conjugate_view_key_height_3x3).toInt()
}
} else {
Log.i("≠", "The current state is not conjugate view")
Log.i(TAG, "The current state is not conjugate view")
when (resources.configuration.orientation) {
Configuration.ORIENTATION_LANDSCAPE -> {
res.getDimension(R.dimen.key_height_landscape).toInt()
Expand Down
8 changes: 5 additions & 3 deletions app/src/main/java/be/scri/ui/screens/LanguageSettingsScreen.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,8 @@ import be.scri.ui.common.components.ItemCardContainerWithTitle
import be.scri.ui.models.ScribeItem
import be.scri.ui.models.ScribeItemList

private const val TAG = "LanguageSettingsScreen"

/**
* Data class to hold functionality settings state and callbacks
*/
Expand Down Expand Up @@ -387,7 +389,7 @@ private fun getLayoutListData(
title = R.string.i18n_app_settings_keyboard_layout_default_layout,
desc = R.string.i18n_app_settings_keyboard_layout_default_layout_description,
action = {
Log.d("Navigation", "onDefaultLayoutSelect clicked")
Log.d(TAG, "onDefaultLayoutSelect clicked")
onDefaultLayoutSelect()
},
),
Expand All @@ -398,7 +400,7 @@ private fun getLayoutListData(
title = R.string.i18n_app_settings_keyboard_layout_default_currency,
desc = R.string.i18n_app_settings_keyboard_layout_default_currency_description,
action = {
Log.d("Navigation", "onCurrencySelect clicked")
Log.d(TAG, "onCurrencySelect clicked")
onCurrencySelect()
},
),
Expand Down Expand Up @@ -470,7 +472,7 @@ private fun getTranslationSourceLanguageListData(onTranslationLanguageSelect: ()
title = R.string.i18n_app_settings_keyboard_translation_select_source,
desc = R.string.i18n_app_settings_keyboard_translation_select_source_description,
action = {
Log.d("Navigation", "onTranslationLanguageSelect clicked")
Log.d(TAG, "onTranslationLanguageSelect clicked")
onTranslationLanguageSelect()
},
),
Expand Down
4 changes: 3 additions & 1 deletion app/src/main/java/be/scri/views/KeyboardView.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,8 @@ import be.scri.models.ScribeState
import java.util.Arrays
import java.util.Locale

private const val TAG = "SoundCheck"

/**
* The base keyboard view for Scribe language keyboards application.
*/
Expand Down Expand Up @@ -685,7 +687,7 @@ class KeyboardView
}

fun soundIfNeeded() {
Log.d("Souncheck", "soundIfNeeded: $setSound")
Log.d(TAG, "soundIfNeeded: $setSound")
if (setSound) {
performSoundFeedback()
}
Expand Down
Loading