Localize clipboard accessibility labels#647
Conversation
Thank you for the pull request! 💙🩵The Scribe-Android team will do our best to address your contribution as soon as we can. The following are some important points:
Note Scribe uses Conventional Comments in reviews to make sure that communication is as clear as possible. |
Maintainer ChecklistThe following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)
|
There was a problem hiding this comment.
First PR Commit Check
- The commit messages for the remote branch should be checked to make sure the contributor's email is set up correctly so that they receive credit for their contribution
- The contributor's name and icon in remote commits should be the same as what appears in the PR
- If there's a mismatch, the contributor needs to make sure that the email they use for GitHub matches what they have for
git config user.emailin their local Scribe-Android repo (can be set withgit config --global user.email "GITHUB_EMAIL")
|
Thanks for the PR, @ahfoysal! We have the texts for all applications in the Scribe-i18n project, which is a git subtree of this project that allows us to localize in one repo and share across the iOS and Android apps. Would you want to open up a PR on that project with these new strings, and then we can merge those changes into this repo? |
Contributor checklist
./gradlew lintKotlin detekt testcommand as directed in the testing section of the contributing guideDescription
Moves the clipboard panel close and clear-all content descriptions into string resources so TalkBack labels can be localized with the rest of the clipboard text.
Checked with
./gradlew :app:processKeyboardsDebugResources.Related issue