[UEPR-594] Focus outline#572
Open
kbangelov wants to merge 2 commits into
Open
Conversation
KManolov3
reviewed
May 20, 2026
| /* Focus outline for tabs */ | ||
| .tab:focus-visible, | ||
| .tab.is-selected:focus-visible { | ||
| outline: 2px solid $ui-black; |
Contributor
There was a problem hiding this comment.
Should this be rem based?
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates Scratch GUI styling to improve focus visibility by standardizing focus outline color to black and refining tab focus/selection outline behavior (UEPR-594).
Changes:
- Introduces an opaque
$ui-blackcolor token for consistent black usage. - Applies a global
:focus-visibleoutline color of$ui-black. - Updates tab styling to suppress react-tabs pseudo-element styling and adds a clearer keyboard-focus outline for tabs.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/scratch-gui/src/css/colors.css | Adds $ui-black color token for reuse across GUI styles. |
| packages/scratch-gui/src/components/gui/gui.css | Sets global focus-visible outline color and improves tab focus-visible outline styling. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves
To resolve https://scratchfoundation.atlassian.net/browse/UEPR-594 soon
Proposed Changes