Skip to content

[UEPR-523] Update Share Modal Flow#494

Open
adzhindzhi wants to merge 3 commits intoscratchfoundation:developfrom
adzhindzhi:feat/add-sharing-to-project-watcher
Open

[UEPR-523] Update Share Modal Flow#494
adzhindzhi wants to merge 3 commits intoscratchfoundation:developfrom
adzhindzhi:feat/add-sharing-to-project-watcher

Conversation

@adzhindzhi
Copy link
Contributor

@adzhindzhi adzhindzhi commented Mar 23, 2026

Resolves

Proposed Changes

  • Wait for project to be shared in Project Watcher before moving to www

Reason for Changes

  • Now that the manual thumbnail update is moved to the editor, we want to display the Share Modal inside the editor and move to www after the project was actually shared

Test Coverage

Existing tests complete successfully; no new test cases added

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the editor’s Share/Community transition behavior so navigation to the project page can be delayed until the project has completed relevant background operations (saving and, for Share, sharing), aligning with the updated share modal flow in UEPR-523.

Changes:

  • Extends ProjectWatcher to track both “saving” and “sharing” wait conditions.
  • Updates MenuBar to pass structured wait conditions into ProjectWatcher and to provide isShared for the Share flow.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.

File Description
packages/scratch-gui/src/containers/project-watcher.jsx Reworks watcher state/logic to support waiting on save + share completion before firing onDoneUpdating.
packages/scratch-gui/src/components/menu-bar/menu-bar.jsx Updates Share/Community click handlers to use new waitForUpdate API; passes isShared into watcher for Share flow.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Contributor

@KManolov3 KManolov3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link
Contributor

@kbangelov kbangelov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants