[UEPR-523] Update Share Modal Flow#494
Open
adzhindzhi wants to merge 3 commits intoscratchfoundation:developfrom
Open
[UEPR-523] Update Share Modal Flow#494adzhindzhi wants to merge 3 commits intoscratchfoundation:developfrom
adzhindzhi wants to merge 3 commits intoscratchfoundation:developfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the editor’s Share/Community transition behavior so navigation to the project page can be delayed until the project has completed relevant background operations (saving and, for Share, sharing), aligning with the updated share modal flow in UEPR-523.
Changes:
- Extends
ProjectWatcherto track both “saving” and “sharing” wait conditions. - Updates
MenuBarto pass structured wait conditions intoProjectWatcherand to provideisSharedfor the Share flow.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| packages/scratch-gui/src/containers/project-watcher.jsx | Reworks watcher state/logic to support waiting on save + share completion before firing onDoneUpdating. |
| packages/scratch-gui/src/components/menu-bar/menu-bar.jsx | Updates Share/Community click handlers to use new waitForUpdate API; passes isShared into watcher for Share flow. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves
Proposed Changes
Reason for Changes
Test Coverage
Existing tests complete successfully; no new test cases added