Fix full_field_name argument#42
Open
keestux wants to merge 2 commits into
Open
Conversation
This is a bugfix of a change made in commit 0b0a72f
The function always full_field_name tried to use .application_id, but some devices (e.g. Wahoo ELMNT) does not have it.
keestux
force-pushed
the
fix/full-field-name
branch
from
cf0b01f to
f416c07
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Besides a fix of the
full_field_nameargument there is also a change to avoid usingapplication_id, because that field is not present in Wahoo FIT files.