fix: allow 'N {interval} from now' (#502)#1271
Merged
Gallaecio merged 3 commits intoscrapinghub:masterfrom Feb 5, 2026
Merged
Conversation
|
Can we get this merged? Would like to have support for "* from now" format |
Member
|
Closing and reopening to see if CI triggers. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1271 +/- ##
=======================================
Coverage 96.58% 96.58%
=======================================
Files 235 235
Lines 2866 2866
=======================================
Hits 2768 2768
Misses 98 98 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
It seems tests do not pass. |
Fixes test failure by moving "from now" test cases from test_relative_past_dates to test_relative_future_dates.
Contributor
Author
|
The test cases were decorating the wrong function, they should pass now. |
|
Any further news on this? This is perhaps the most common timedelta construction in natural language English. |
Gallaecio
approved these changes
Feb 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a copy of PR #642 which fixes #502. I'm not sure why it was closed, or if this is the right way to re-submit it. Afaict it's a general fix that works in all cases.
Before:
After: