wing name format compatibility and other cleanup - #7732
Open
Goober5000 wants to merge 1 commit into
Open
Conversation
Goober5000
added
fix
Goober5000
marked this pull request as draft
August 22, 2026 19:47
Following PR scp-fs2open#7429, ships belonging to wings were hashed the same way as every other ship. This was a mostly transparent implementation detail, but it was still possible for ships to be saved in older missions in the legacy format. Adding compatibility checks required several layers of changes: - Extra handling to `eval_ship` and `ship_registry_get` to accommodate legacy names - A parse flag to indicate when the mission was being parsed, and a new `ship_class_index()` accessor in the ship registry, albeit both currently unused - Refine FRED handling of ship registry staleness
Goober5000
force-pushed
the
fix/wing_hash_compatibility
branch
from
August 23, 2026 03:13
14e002c to
7de169d
Compare
Goober5000
marked this pull request as ready for review
August 23, 2026 03:13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following PR #7429, ships belonging to wings were hashed the same way as every other ship. This was a mostly transparent implementation detail, but it was still possible for ships to be saved in older missions in the legacy format. Adding compatibility checks required a few layers of changes:
eval_shipandship_registry_getto accommodate legacy namesship_class_index()accessor in the ship registry, albeit both currently unused