Skip to content

Fix Campaign Editor Crash #7722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JohnAFernandez merged 1 commit into from
Aug 20, 2026
Merged

Fix Campaign Editor Crash #7722

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions qtfred/src/ui/widgets/CampaignMissionGraph.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1154,6 +1154,7 @@ void CampaignMissionGraph::mousePressEvent(QMouseEvent* ev)

// Recheck pointer right before using it again
if (!n) {
m_drag.active = false;
ev->ignore();
return;
}
Expand All @@ -1163,6 +1164,14 @@ void CampaignMissionGraph::mousePressEvent(QMouseEvent* ev)

// Build preview edge
const auto& missions = m_model->getCampaignMissions();

// quickly check for this, as we can drag the end mission sink that is not supposed to be dragged, by accident
if (!SCP_vector_inbounds(missions, m_drag.fromIndex)){
m_drag.active = false;
ev->ignore();
return;
}

const auto mode = missions[m_drag.fromIndex].special_mode_hint;

m_drag.preview = new detail::EdgeItem(m_drag.fromIndex, /*branchId*/ -1, m_drag.isSpecial, mode, m_style);
Expand Down
Loading