Skip to content

Capture ImGui in screenshots #7236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MjnMixael wants to merge 1 commit into
base: master
Choose a base branch
from
+7 −3
Open

Capture ImGui in screenshots #7236

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions code/graphics/opengl/gropengl.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -281,10 +281,14 @@ void gr_opengl_print_screen(const char *filename)
_mkdir(os_get_config_path("screenshots").c_str());

GL_state.PushFramebufferState();
GL_state.BindFrameBuffer(Cmdline_window_res ? Back_framebuffer : 0, GL_FRAMEBUFFER);

//Reading from the front buffer here seems to no longer work correctly; that just reads back all zeros
glReadBuffer(Cmdline_window_res ? GL_COLOR_ATTACHMENT0 : GL_FRONT);
// Screenshots are requested during input processing which can happen before all overlays are rendered for the
// current frame (such as with ImGui). In window res mode the in progress frame is rendered to Back_framebuffer,
// so reading from that can miss late overlays. Read the currently displayed image from the default framebuffer
// instead.
GL_state.BindFrameBuffer(0, GL_FRAMEBUFFER);
// Read the displayed frame to include any overlays rendered after the scene pass.
glReadBuffer(GL_FRONT);

// now for the data
if (Use_PBOs) {
Expand Down