Open
Conversation
naomimyselfandi
approved these changes
Feb 17, 2026
Contributor
There was a problem hiding this comment.
Lgtm. Mjn described his test plan to me on Discord; it included the first and second waves of a wing with display names, the first and second waves of a wing without display names as a regression test, and save/load round trips in both FRED and QtFred. We also discussed the decision to let wing display names override ship display names. Arguably, a ship display name "should" override a wing display name, but it introduces legitimate ambiguity around how waves after the first should be handled; in light of the historical baggage around ship display names, we agreed that simplicity was preferable. (ship-change-display-name remains an option for special cases, with or without a wing display name.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds Display name for wings. Fixes #1730 (the last request from that ticket).
Wing display name takes priority over ship display name in all cases. Works for the initial wing and all following waves.
There's a lot of baggage and edge cases with ship display names. I deliberately wanted to avoid all of that. Since this is a new feature, no mods can have used it yet so we can be reasonably sure that if wing display name is parsed then that's the display name we want to use. I'm sure there are plenty of edge cases and tweaks that will come up as mods start picking up the feature but for now this solves what BtA really needs and gets wing display name on the bus. We can refine it as mods make requests later. This simple feature allows, finally, translating wing names without hacks.