Skip to content

Stop select model rendering destroyed subsystems#7225

Open
MjnMixael wants to merge 1 commit intoscp-fs2open:masterfrom
MjnMixael:fix_select_model_rendering
Open

Stop select model rendering destroyed subsystems#7225
MjnMixael wants to merge 1 commit intoscp-fs2open:masterfrom
MjnMixael:fix_select_model_rendering

Conversation

@MjnMixael
Copy link
Contributor

Fixes #7158 where destroyed submodels were being rendered simultaneously with regular submodels for ship/weapon select rotating and overhead model rendering.

This was likely caused when these render methods were converted to be more independent so the Lua API could call them arbitrarily for SCPUI. Or maybe it was always like this, I can't really remember.

The root cause was that these methods were using a shorthand method for render calls that did not require a model instance. Without the model instance the subsystem data never gets setup so all submodels are just rendered without concern. I first thought a simple fix would be a new MR_ flag to skip -destroyed rendering and that did work. But further research revealed that tech model rendering prefers a full instance create/delete every frame specifically to avoid this issue. It's more churn every frame than the flag but I opted for consistency in this case especially since in the UI we don't have all that much going on anyway.

@wookieejedi wookieejedi added the fix A fix for bugs, not-a-bugs, and/or regressions. label Feb 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fix A fix for bugs, not-a-bugs, and/or regressions.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Destroyed submodels render in the ship selection screen

2 participants