[ Fix : Stored the commented_user Id and Used it to Show Avatar ]#1211
Open
rohitPandey469 wants to merge 1 commit intoscorelab:masterfrom
Open
[ Fix : Stored the commented_user Id and Used it to Show Avatar ]#1211rohitPandey469 wants to merge 1 commit intoscorelab:masterfrom
rohitPandey469 wants to merge 1 commit intoscorelab:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
getCurrentUserDatato fetch user data in TutorialPage component.addCommentaction get called. Now, the comments have their userId and we can use it to fetch the userData.getUserProfileDatawith the userId and fetched the value and used it to show Avatar.Now, fetching it inside the component doesn't seem good but we are using the same component for every Avatar's so I am thinking of sending the user data directly into the component. Well, it's something I am just thinking
Related Issue
Fixes #1198
Motivation and Context
Fixing the Avatars so I can differentiate who wrote which/what/why comments.
How Has This Been Tested?
Locally On my machine.
Video:
Codelabz.-.Google.Chrome.2024-02-19.16-35-35.mp4
Types of changes
Checklist: