Add high resolution sources for all ESS instruments#139
Open
Add high resolution sources for all ESS instruments#139
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add sources generated with McStas notebook for all 16 instruments.
The new default ess source is created as the average of all sources.
The high-resolution binning will then enable us to use uniform noise during the sample instead of gaussian noise, which would fix issues in sampling optimization in #136
We also add the notebook that was used to generate the sources. It is not ran as part of the docs, as it is too expensive to run in CI.
Updated default ESS source profile:
