Conversation
pyproject.toml
Outdated
| [project.optional-dependencies] | ||
| scipp = ["scipp>=25.5.0"] | ||
| scipp = ["scipp>=25.8.0"] | ||
| all = ["scipp>=25.5.0", "ipympl>0.8.4", "pythreejs>=2.4.1", "mpltoolbox>=24.6.0", "ipywidgets>=8.1.0", "graphviz>=0.20.3"] |
There was a problem hiding this comment.
shouldn't this be bumped here too?
Also maybe use the plopp[scipp] syntax so we need to bump only one?
There was a problem hiding this comment.
Good catch.
Also maybe use the plopp[scipp] syntax so we need to bump only one?
Where should I do this?
| scipp = ["scipp>=25.5.0"] | ||
| all = ["scipp>=25.5.0", "ipympl>0.8.4", "pythreejs>=2.4.1", "mpltoolbox>=24.6.0", "ipywidgets>=8.1.0", "graphviz>=0.20.3"] | ||
| scipp = ["scipp>=25.8.0"] | ||
| all = ["plopp[scipp]", "ipympl>0.8.4", "pythreejs>=2.4.1", "mpltoolbox>=24.6.0", "ipywidgets>=8.1.0", "graphviz>=0.20.3"] |
There was a problem hiding this comment.
So does it not matter that plopp depends on itself? (apparently not? CI seems happy...)
There was a problem hiding this comment.
But it's now pinning plopp[scipp]==26.3.1 though.
Does it now pulling released plopp or does it pick up the source folder first ...?
There was a problem hiding this comment.
Does it now pulling released plopp or does it pick up the source folder first ...?
It shouldn't pull in plopp as it only resolves scipp (plopp isn't added to the *.txt files)
So does it not matter that plopp depends on itself?
No, recursive dependencies should work and this is just not a well documented feature pypa/pip#11296
| plopp[scipp]==26.3.1 | ||
| # via -r basetest.in |
There was a problem hiding this comment.
@MridulS I got confused becuase of this line.
So.... this... doesn't install plopp, but just its scipp extra dependencies...?
Then I'm fine with it. 👍
4 participants
Fixes lower bound test CI failure.