-
Notifications
You must be signed in to change notification settings - Fork 3
fix: reduction workflow for 3D BEER detectors #254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 3 commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
9d3af21
fix: make sure coord remains after binnning
jokasimr e525a3b
test: skip if cif-db not reachable
jokasimr e09ee62
Merge branch 'main' into fix-beer-3d
jokasimr 561b787
fix: make sure coord remains after binnning
jokasimr 28545d6
test: skip if cif-db not reachable
jokasimr 93a1b0a
Merge branch 'fix-beer-3d' of github.com:scipp/essdiffraction into fi…
jokasimr d9890bc
feat: round fitted t0 to nearest chopper opening
jokasimr cbe5572
remove comment
jokasimr a0a4715
refactor: better name for frame cutoff time coordinate
jokasimr 9116608
Merge branch 'main' into fix-beer-3d
jokasimr 01672d2
test: add test reducing 3D dataset using automatic peak finder workflow
jokasimr 7ab0faf
Merge branch 'fix-beer-3d' of github.com:scipp/essdiffraction into fi…
jokasimr 715c389
refactor: better name for chopper delay
jokasimr 80863ab
docs: explain rounding step
jokasimr 3bacfd3
Merge remote-tracking branch 'origin/main' into fix-beer-3d
jokasimr 2cfcc83
docs: motivation for clamping origin times
jokasimr 8250cc0
docs: reformulate
jokasimr 73769bf
Merge branch 'main' into fix-beer-3d
jokasimr File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why can we just use the mean here? Shouldn't this be a per-cluster coord?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should really be a "per Ltotal" coord. But there is no binning here that has that granularity, so either it is per event or a scalar.
The name was bad so I renamed
tctoframe_cutoff_time.