Allow Kmapper to take in list of clusterers#246
Open
justin5927 wants to merge 3 commits intoscikit-tda:masterfrom
Open
Allow Kmapper to take in list of clusterers#246justin5927 wants to merge 3 commits intoscikit-tda:masterfrom
justin5927 wants to merge 3 commits intoscikit-tda:masterfrom
Conversation
…the options to have a different clusterer be applied to each slice
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently only one clusterer can be inputted and it is applied to all of the slices equally. Our proposed change allows for a list of clusterers to be inputted so that a different clusterer (method or parameter change) can be applied to each slice. This change still allows for a single clusterer to be inputted as well.
Please let us know any thoughts on this type of the methodology for clustering on each slice.