build: Use Typer for CLI#1675
Draft
matthewfeickert wants to merge 10 commits intomainfrom
Draft
Conversation
https://typer.tiangolo.com/tutorial/options/version/#fix-with-is_eager used to be: pyhf, version {version} now is: pyhf, v{version}
matthewfeickert
added
build
Member
|
FYI, typer is completely broken due to click 8.1, see pallets/click#2226 or the typer issue. |
Member
Author
Yeah I think this PR is going to be in stasis for quite some time (even before you pointed this out), but I didn't want to close it yet. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Resolves #1674
Use Typer to provide the CLI API
Checklist Before Requesting Reviewer
Before Merging
For the PR Assignees: