[Snyk] Security upgrade django from 1.11.29 to 4.2.28#1489
[Snyk] Security upgrade django from 1.11.29 to 4.2.28#1489robertatakenaka wants to merge 1 commit intobetafrom
Conversation
The following vulnerabilities are fixed by pinning transitive dependencies: - https://snyk.io/vuln/SNYK-PYTHON-DJANGO-15183335
There was a problem hiding this comment.
Pull request overview
Updates the development dependency list to address a Snyk-reported Django vulnerability by introducing an explicit Django version constraint in dev requirements.
Changes:
- Add
django>=4.2.28torequirements-dev.txtwith a Snyk-generated comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| coverage | ||
| django-coverage | ||
| Fabric==1.4.3 | ||
| django>=4.2.28 # not directly required, pinned by Snyk to avoid a vulnerability |
There was a problem hiding this comment.
Dependency name casing is inconsistent with the rest of this repo: requirements.txt uses Django (capitalized) while this adds django. Pip treats names case-insensitively, but keeping casing consistent reduces diff churn and tooling inconsistencies (e.g., grep/audit scripts).
| coverage | ||
| django-coverage | ||
| Fabric==1.4.3 | ||
| django>=4.2.28 # not directly required, pinned by Snyk to avoid a vulnerability |
There was a problem hiding this comment.
This change doesn’t match the PR description (“upgrade django from 1.11.29 to 4.2.28” to fix a vulnerability): the repo’s declared Django requirement is currently Django<1.5 (requirements.txt:1), and the new constraint is only added to requirements-dev.txt. If the vulnerability is relevant to runtime, it won’t be addressed by a dev-only dependency; if it’s dev-only, the project’s Django constraint/version should be clarified so dependency scanning results are consistent.
Snyk has created this PR to fix 1 vulnerabilities in the pip dependencies of this project.
Snyk changed the following file(s):
requirements-dev.txtImportant
Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic
Learn how to fix vulnerabilities with free interactive lessons:
🦉 SQL Injection