The current httpx doesn't support proxies arguments:#564
Merged
arunkannawadi merged 1 commit intoscholarly-python-package:developfrom Apr 28, 2025
Merged
The current httpx doesn't support proxies arguments:#564arunkannawadi merged 1 commit intoscholarly-python-package:developfrom
arunkannawadi merged 1 commit intoscholarly-python-package:developfrom
Conversation
1 task
Collaborator
|
Thank you for this patch that avoids the deprecated, and now removed keyword. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#561
The current httpx doesn't support proxies arguments:
https://github.com/encode/httpx/blob/master/httpx/_client.py#L239
Fixes #Enter the associated issue number.
Description
Describe your addition briefly to help the reviewers understand your contribution.
Checklist
developand notmain.If you don't have a premium proxy, some of the tests will be skipped.
The tests that are run should pass without raising
MaxTriesExceededExceptionor other exceptions.