Send X-Scal-Request-Uids (not x-scal-request-id) on the management config poll#6218
Open
delthas wants to merge 2 commits into
Open
Send X-Scal-Request-Uids (not x-scal-request-id) on the management config poll#6218delthas wants to merge 2 commits into
delthas wants to merge 2 commits into
Conversation
Contributor
Hello delthas,My role is to assist you with the merge of this Available options
Available commands
Status report is not available. |
Contributor
Waiting for approvalThe following approvals are needed before I can proceed with the merge:
|
❌ 1 Tests Failed:
View the full list of 2 ❄️ flaky test(s)
To view more test analytics, go to the Test Analytics Dashboard |
Formatting-only commit: run Prettier on lib/management/poll.js, which was already prettier-dirty at the base commit, so the functional change on top stays prettier-clean and diff-minimal. Issue: CLDSRV-948
The management config-overlay poll emitted the werelogs req_id chain under the wrong header name. Rename the outgoing header from x-scal-request-id to x-scal-request-uids, matching cloudserver's own reader in lib/server.js. Also export loadRemoteOverlay and add a unit test asserting the header is sent. Issue: CLDSRV-948
7746fec to
f2ca340
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The management config-overlay poll (
lib/management/poll.js,loadRemoteOverlay) sent the werelogsreq_idchain under the wrongheader name
x-scal-request-id. Rename the outgoing header tox-scal-request-uids, which matches cloudserver's own reader inlib/server.js. The value (log.getSerializedUids()) is unchanged.Pure rename: no dual-send. Also exports
loadRemoteOverlayand adds afocused unit test asserting the outgoing request carries
x-scal-request-uidsand notx-scal-request-id.Issue: CLDSRV-948